Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ArrayList with List<T> in TableLayoutPanelBehavior #10260

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Replace ArrayList with List<T> in TableLayoutPanelBehavior #10260

merged 3 commits into from
Nov 14, 2023

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Nov 9, 2023 •
edited by ghost
Loading

Contributes to #8140

I fixed the field name in the same PR (in a separate commit) to make it easier to review all the call sites of this field

Proposed changes

  • Replace ArrayList styles with List<TableLayoutStyle> _styles in TableLayoutPanelBehavior
Microsoft Reviewers: Open in CodeFlow

@halgab halgab requested a review from a team as a code owner November 9, 2023 08:17
@ghost ghost assigned halgab Nov 9, 2023
lonitra
lonitra reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments otherwise LGTM!

...em.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/TableLayoutPanelBehavior.cs Outdated Show resolved Hide resolved
...em.Windows.Forms.Design/src/System/Windows/Forms/Design/Behavior/TableLayoutPanelBehavior.cs Outdated Show resolved Hide resolved
@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label Nov 13, 2023
@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Nov 13, 2023
@halgab halgab requested a review from lonitra November 13, 2023 20:06
@halgab halgab force-pushed the TableLayoutPanelBehavior-ArrayList branch from 5aee892 to f8ebf19 Compare November 13, 2023 22:04
@lonitra lonitra merged commit a6cebed into dotnet:main Nov 14, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Nov 14, 2023
@halgab halgab deleted the TableLayoutPanelBehavior-ArrayList branch November 14, 2023 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra approved these changes

Assignees

@halgab halgab

Labels
None yet
Projects
None yet
Milestone
9.0 Preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@halgab @lonitra